fix background-imgae none 的编译error #2226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
reviewed
Sep 18, 2025
| return { prop, value } | ||
| } else { | ||
| error(`Value of ${prop} in ${selector} selector only support value <url()> or <linear-gradient()>, received ${value}, please check again!`) | ||
| value !== 'none' && error(`Value of ${prop} in ${selector} selector only support value <url()> or <linear-gradient()>, received ${value}, please check again!`) |
Collaborator
There was a problem hiding this comment.
不应该在这里处理，应该在上面条件中识别none，并且返回none，在运行时中处理none
Collaborator
There was a problem hiding this comment.
否则通过css var声明的none同样无法得到正确处理
hiyuki
reviewed
Sep 29, 2025
| if (value === 'none') { | ||
| return [ | ||
| { prop: bgPropMap.image, value }, | ||
| { prop: bgPropMap.color, value: 'transparent' } |
hiyuki
reviewed
Sep 29, 2025
| const { textStyle, backgroundStyle, innerStyle = {} } = splitStyle(normalStyle) | ||
|
|
||
| enableBackground = enableBackground || !!backgroundStyle | ||
| enableBackground = enableBackground || (!!backgroundStyle && backgroundStyle.backgroundImage !== 'none') |
Collaborator
There was a problem hiding this comment.
不应该影响enableBackground，应该在parseBgImage中修改if (!text || text==='none') return {}
hiyuki
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.